Some consistency changes to subgrad_distance #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
Co-authored-by: Ronny Bergmann <git@ronnybergmann.net>
# Conflicts: # src/subgradients.jl # test/test_subgradients.jl
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 95.02% 95.08% +0.05%
==========================================
Files 20 15 -5
Lines 342 305 -37
==========================================
- Hits 325 290 -35
+ Misses 17 15 -2
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kellertuer
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes default exponent to be used in the subgrad_distance function to 2 to mimic the behavior of grad_distance, and changes default atol to 0.
Finally, returns a tangent vector rescaled by rand() after having normalized it, since any tangent vector of norm less than or equal to one is a subgradient of the distance for p=q. This should make it closer to sampling from a normal cone.