Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more consistency changes to subgrad_distance #32

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

hajg-ijk
Copy link
Member

I updated the docs to actually reflect the correct default exponent (c=2), and replaced instances where 0 and 1.0 occurred with zero and one respectively.
Finally, I added subgrad_distance to the exported functions.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #32 (507516c) into main (cf4a488) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 507516c differs from pull request most recent head 254f2f3. Consider uploading reports for the commit 254f2f3 to get more accurate results

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   95.26%   95.20%   -0.06%     
==========================================
  Files          20       15       -5     
  Lines         359      313      -46     
==========================================
- Hits          342      298      -44     
+ Misses         17       15       -2     
Files Changed Coverage Δ
src/ManifoldDiff.jl 96.00% <ø> (-0.67%) ⬇️
src/subgradients.jl 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe still bump the version so we can register this patch.

@hajg-ijk
Copy link
Member Author

Right, I totally forgot about that.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have one minor comment.

src/subgradients.jl Outdated Show resolved Hide resolved
@hajg-ijk hajg-ijk merged commit ef69a8e into JuliaManifolds:main Sep 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants