Update for ManifoldsBase 0.15 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbaran
added
preview docs
|
@kellertuer We can't get CI passing here without merging JuliaManifolds/Manifolds.jl#642 (comment) and tagging it, and we can't get CI passing there without merging and tagging this PR 😞 . |
|
I do not follow why that is the case, how did we manage to get this deadlock? If both work for you locally we could merge and register both. |
|
Manifolds.jl is a test dependency of ManifoldDiff.jl -- this is the issue. I will re-check tests here, I'm not sure if I tested it on the latest commit of 0.15. |
|
or to be more precise, I was hoping, Manifolds.jl works without Diff. |
|
ManifoldDiff.jl is a hard dependency of Manifolds.jl. |
|
ManifoldDiff.jl works locally, so I will merge and tag it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JuliaManifolds/ManifoldsBase.jl#170