Random point for tangent space

[const-ae]

I wrote a random_point() and random_tangent() function for the TangentSpaceAtPoint manifolds. Both are pretty straightforward, as they both simply call random_tangent() for the original manifold. Let me know if you think that could be a useful contribution.

[codecov]

Codecov Report

Merging #111 (35cdd6f) into master (cdaeee4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          47       47           
  Lines        3023     3027    +4     
=======================================
+ Hits         3012     3016    +4     
  Misses         11       11           

Impacted Files	Coverage Δ
src/Manopt.jl	100.00% <ø> (ø)
src/helpers/random.jl	100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[kellertuer]

Sure sounds reasonable (though simple), could you check for the 4 lines missing in code coverage, i.e. also write tests for your new functions?

The docs look okay, but could also be a little longer.

[const-ae]

I am getting an error when I access the code coverage report: https://app.codecov.io/gh/JuliaManifolds/Manopt.jl/compare/111?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr%20comments&utm_term=JuliaManifolds

No idea what's happening there, because I do have tests for the new functions (https://github.com/JuliaManifolds/Manopt.jl/pull/111/files#diff-aa4320949f987b556afb5c0fbfb0e95e09a8c07bf72fc82aa478196179db22acR58-R65). I wonder if it is related to the fact that this PR builds upon #110.

[const-ae]

The docs look okay, but could also be a little longer.

I will see if I can add a bit more text tomorrow :)

[kellertuer]

Does the direct comparison link work?
https://app.codecov.io/gh/JuliaManifolds/Manopt.jl/compare/111/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr%20comments&utm_term=JuliaManifolds#diff-c3JjL2hlbHBlcnMvcmFuZG9tLmps

It seems for now your new functions are not called

Also you have to merge master once to here in order to be able to merge this later on.

[mateuszbaran]

Thanks for the contribution! The coverage is not detected because your new tests are in a file that is not run during CI. You need to include() test_random.jl in test/runtests.jl.

[kellertuer]

Ah that I did not see that fast then even on the current master these are not run – but luckily now they are :)

[kellertuer]

this one is nearly ready to merge, we are just missing code coverage for the 4 new lines it seems?

[const-ae]

Great. I will take a look tomorrow :)

[kellertuer]

(Sorry for the little delay) if you could bump the version to 0.3.19 we could also directly register this so its available for everyone who updates.
Then I can directly merge this :)