Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation of multiset_permutations #141

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

kunzaatko
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac70c46) 96.97% compared to head (d27455c) 96.89%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   96.97%   96.89%   -0.09%     
==========================================
  Files           7        8       +1     
  Lines         728      804      +76     
==========================================
+ Hits          706      779      +73     
- Misses         22       25       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/permutations.jl Outdated Show resolved Hide resolved
@inkydragon inkydragon added the doc documentation label Feb 2, 2024
Change documentation to admit only two arguments in `multiset_permutations`

Co-authored-by: inky <git@wo-class.cn>
@kunzaatko
Copy link
Contributor Author

OK, so now the documentation shows the option with two arguments instead of three at the beginning, which is correct, if I understand you correctly?

Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inkydragon inkydragon merged commit a303e88 into JuliaMath:master Feb 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants