Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ini_hex, ini_HEX #125

Merged
merged 1 commit into from
May 2, 2021
Merged

Conversation

GregPlowman
Copy link
Contributor

When precompiling DoubleFloats, I'm getting this warning:

Julia-1.6.1> using DoubleFloats
[ Info: Precompiling DoubleFloats [497a8b3b-efae-58df-a0af-a86822472b78]
WARNING: could not import Printf.ini_hex into DoubleFloats
WARNING: could not import Printf.ini_HEX into DoubleFloats

Firstly, I don't really understand this code.

But it seems ini_hex and ini_HEX are not used in this file (src/type/show.jl).

Also it seems Printf no longer uses ini_hex and ini_HEX.
I think they were removed in "Rewrite printf functionality" #32859

Printf no longer uses ini_hex and ini_HEX
Removed in "Rewrite printf functionality" #32859
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #125 (4832ff5) into master (7814faf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   45.86%   45.86%           
=======================================
  Files          63       63           
  Lines        3203     3203           
=======================================
  Hits         1469     1469           
  Misses       1734     1734           
Impacted Files Coverage Δ
src/type/show.jl 7.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7814faf...4832ff5. Read the comment docs.

@JeffreySarnoff
Copy link
Member

yes -- thank you Greg.

@JeffreySarnoff JeffreySarnoff merged commit 71f1247 into JuliaMath:master May 2, 2021
ToucheSir added a commit to ToucheSir/BFloat16s.jl that referenced this pull request Jan 4, 2022
Ref. JuliaLang/julia#32859, JuliaMath/DoubleFloats.jl#125. This is causing warnings downstream in CUDA.jl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants