Require Julia 1.6+, use Preferences, eliminate mutable state #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Preferences.jl
as the backing store for settinga computation backend (currently only supports
fftw
andmkl
as validchoices). The convenience method
set_provider!()
is given, but it islittle more than a wrapper around
Preferences.set_preferences!()
.Users can alter their
LocalPreferences.toml
orProject.toml
files byhand as well; in the event that an illegal value is provided, an error
will be displayed and
fftw
will be chosen as the default value.Preferences is a relatively new subsystem in Julia and it has some
lacking support in
Pkg
; so for now we are adding a separatetest/Project.toml
, which will have preferences added into it on CI, asthere is a bug in propagating preferences when a single
Project.toml
is used with extra dependencies for the tests.