Removed iround, iceil, itrunc etc. #17
Conversation
| ifloor(x::Ufixed) = ifloor(Int, x) | ||
| iceil(x::Ufixed) = iceil(Int, x) | ||
| trunc{T<:Integer}(::Type{T}, x::Ufixed) = convert(T, div(reinterpret(x), rawone(x))) | ||
| round{T<:Integer}(::Type{T}, x::Ufixed) = (@show T;round(T, reinterpret(x)/rawone(x))) |
There was a problem hiding this comment.
You are right, I missed it. Removed.
|
FixedPointNumbers isn't a very active repo, so a fork for 0.3 might not be a big problem, but it is not an ideal situation. |
|
Compat.jl recently added functionality for this. |
|
@pwl, all you need to do is add |
|
Thanks, @pwl! I inadvertently caused you some trouble by merging another pending PR, so I went ahead and resolved the conflicts myself. Your commit is visible at https://github.com/JeffBezanson/FixedPointNumbers.jl/commits/master. |
|
Thanks for resolving the conflicts. I tried to rebase but run into some problems with git due to my lack of experience with it. |
|
New version tagged. |
Hi, after pulling from Julia master ProfileView I started getting deprecation messages about iround and similar functions. Going down the rabbit hole I managed to fix it with this commit. The tests pass but I have no idea how FixedPointNumbers work so you should definitely check whether I didn't break anything.
EDIT: Tests fail for juliareleases, I guess this might be a problem.