Improve throw_converterror
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 89.74% 89.83% +0.08%
==========================================
Files 6 6
Lines 478 482 +4
==========================================
+ Hits 429 433 +4
Misses 49 49
Continue to review full report at Codecov.
|
This uses the type aliases for the message and avoids showing huge numbers. This also reduces the compilation time, i.e. the CI time.
timholy
approved these changes
Jul 24, 2020
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
This uses the type aliases for the message and avoids showing huge numbers. This also reduces the compilation time, i.e. the CI time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188 (comment)
This uses the type aliases for the message and avoids showing huge numbers.
This also reduces the compilation time, i.e. the CI time.
Although the time for testing on the CI is unsettled, this saves about 10 seconds on my local Windows machine. FYI, I could not feel the time saving effect of the
@nospecialize(X)for the first argument.