Add test for unsafe_trunc returning arbitrary values
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 7 7
Lines 782 782
=======================================
Hits 759 759
Misses 23 23 ☔ View full report in Codecov by Sentry. |
kimikage
force-pushed
the
issue288_test
branch
3 times, most recently
from
baceada to
26df4bf
Compare
kimikage
force-pushed
the
issue288_test
branch
3 times, most recently
from
0460bc7 to
307b750
Compare
kimikage
changed the title
unsafe_truncunsafe_trunc returning arbitrary values
kimikage
force-pushed
the
issue288_test
branch
6 times, most recently
from
68c6fca to
9f8ca6b
Compare
|
Fine, everything is broken except the nightly build! In my defense, this was (potentially) broken before I changed it and would have been even more broken if I hadn't. |
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
Apr 30, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 1, 2024
kimikage
added a commit
to kimikage/FixedPointNumbers.jl
that referenced
this pull request
May 13, 2024
kimikage
added a commit
that referenced
this pull request
May 13, 2024
* Backport "Fix test for exponentially growing `promote_type` (#280)" * fix tests on 1.7 (#253) Co-authored-by: Johnny Chen <johnnychen94@hotmail.com> Co-authored-by: kimikage <kimikage.ceo@gmail.com> * Mark `test_broken` for conversion to `Float16` * Backport "Add test for `unsafe_trunc` returning arbitrary values (#289)" --------- Co-authored-by: Kristoffer Carlsson <kricarl@student.chalmers.se> Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for fixing issue #288.
The actual modification will be done in a separate PR.