Fix inference on symmatrix (patch for #472)
#480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid `sqrt`/`power`, thus also work on 1.6 and 1.7.
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
==========================================
+ Coverage 86.37% 86.39% +0.02%
==========================================
Files 26 26
Lines 1732 1735 +3
==========================================
+ Hits 1496 1499 +3
Misses 236 236
Continue to review full report at Codecov.
|
mkitti
reviewed
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hardcoded the output size of
symmatrixfor L < 32 to avoidsqrt/power, thus also work on 1.6 and 1.7.For
L > 32, we'll touch the inference threshold ofTupleanyway. Thus more methods seems meaningless.(I'm not sure why #472 passed previously on 1.7.0. Quite strange.)