Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move methods from DomainSets.jl #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Nov 30, 2022

Currently, DomainSets.jl performs type-piracy with Domain, so this PR is an attempt to move the pirated methods to this package. This involves adding two lightweight dependencies, and the following is the impact on load times:
On master

julia> @time_imports using IntervalSets
     32.6 ms  IntervalSets

This PR

julia> @time_imports using IntervalSets
      3.7 ms  StaticArraysCore
      2.0 ms  CompositeTypes
     36.1 ms  IntervalSets

Tests remain to be added.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 99.16% // Head: 80.26% // Decreases project coverage by -18.89% ⚠️

Coverage data is based on head (00f197c) compared to base (0661291).
Patch coverage: 5.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #127       +/-   ##
===========================================
- Coverage   99.16%   80.26%   -18.90%     
===========================================
  Files           3        4        +1     
  Lines         239      299       +60     
===========================================
+ Hits          237      240        +3     
- Misses          2       59       +57     
Impacted Files Coverage Δ
src/IntervalSets.jl 95.08% <0.00%> (-3.23%) ⬇️
src/domain.jl 5.35% <5.35%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant