-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base.round(x::IrrationalConstant, r::RoundingMode)
#24
Conversation
Pull Request Test Coverage Report for Build 4253675818Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Codecov ReportBase: 97.36% // Head: 97.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 97.36% 97.43% +0.06%
==========================================
Files 2 2
Lines 38 39 +1
==========================================
+ Hits 37 38 +1
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to fix this regression, so I merged the main branch and added some tests. Thanks @hyrodium, feel free to make a follow-up PR if you are unhappy with any of these final changes!
This PR fixes #23.
Before this PR
After this PR
I have not added tests yet because not to make conflicts with #22.