Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed docs issues #342

Merged
merged 3 commits into from
May 14, 2021
Merged

fixed docs issues #342

merged 3 commits into from
May 14, 2021

Conversation

RohitRathore1
Copy link
Contributor

It resolves issue #341 as well.

@jverzani
Copy link
Member

Thanks so much! I'll run the CI and see where we are.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #342 (149647e) into master (ad58cd1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   83.69%   83.69%           
=======================================
  Files          22       22           
  Lines        2453     2453           
=======================================
  Hits         2053     2053           
  Misses        400      400           
Impacted Files Coverage Δ
src/pade.jl 97.61% <ø> (ø)
src/polynomials/LaurentPolynomial.jl 89.41% <ø> (ø)
src/polynomials/multroot.jl 92.38% <ø> (ø)
src/rational-functions/common.jl 63.81% <ø> (ø)
src/show.jl 78.37% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad58cd1...149647e. Read the comment docs.

@RohitRathore1
Copy link
Contributor Author

Thanks so much! I'll run the CI and see where we are.

Thanks. Same error here. I will fix and commit.

@jverzani
Copy link
Member

Hi @RohitRathore1 . This one has one doctest relying on an external package (DualNumbers). https://github.com/JuliaMath/Polynomials.jl/pull/342/checks?check_run_id=2579012823

I think I had that one not tested so CI runs a bit faster.

@RohitRathore1
Copy link
Contributor Author

Hi @RohitRathore1 . This one has one doctest relying on an external package (DualNumbers). https://github.com/JuliaMath/Polynomials.jl/pull/342/checks?check_run_id=2579012823

I think I had that one not tested so CI runs a bit faster.

Yeah, I have got that. I am adding the dependency.

@RohitRathore1
Copy link
Contributor Author

Hi @RohitRathore1 . This one has one doctest relying on an external package (DualNumbers). https://github.com/JuliaMath/Polynomials.jl/pull/342/checks?check_run_id=2579012823

I think I had that one not tested so CI runs a bit faster.

@jverzani are you active on slack right now?

@jverzani
Copy link
Member

jverzani commented May 13, 2021 via email

@jverzani
Copy link
Member

Seems like the only errors are at the round off level. I'm going to merge this in. Thanks so much!

@jverzani jverzani merged commit b63d7e1 into JuliaMath:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants