Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Makie basic recipe #465

Merged
merged 1 commit into from
Feb 8, 2023
Merged

add Makie basic recipe #465

merged 1 commit into from
Feb 8, 2023

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Feb 8, 2023

fix #463

julia> p = Polynomial([1,0,3,4])
Polynomial(1 + 3*x^2 + 4*x^3)

julia> plot(p)

image

julia> scatter(p)

image

@Moelf
Copy link
Contributor Author

Moelf commented Feb 8, 2023

one problem is that this doesn't work smartly:

julia> plot(p; axis=(; limits=(nothing, 3, nothing, nothing)))

image

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 83.23% // Head: 83.12% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (59b38ee) compared to base (8be6bc9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #465      +/-   ##
==========================================
- Coverage   83.23%   83.12%   -0.12%     
==========================================
  Files          22       23       +1     
  Lines        3006     3010       +4     
==========================================
  Hits         2502     2502              
- Misses        504      508       +4     
Impacted Files Coverage Δ
src/makie.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jverzani
Copy link
Member

jverzani commented Feb 8, 2023

Awesome!

I'm not sure what to expect in your example with nothing in the limits. Is there something on the Polynomials side we should be doing?

If not, let me know that this is good to merge and I'll merge it in.

@Moelf
Copy link
Contributor Author

Moelf commented Feb 8, 2023

not much, per @asinghvi17 's comments on Slack, we can potentially make a new "full recipe" so that we can inspect the limits of the plot and produce p.(xs) accordingly.

But I think if user is superimposing a polynomial they probably need to manually make xs and poly.(xs) anyway.

I say we can merge.

@jverzani
Copy link
Member

jverzani commented Feb 8, 2023

Great. Many thanks!

@jverzani jverzani merged commit 2c14b8f into JuliaMath:master Feb 8, 2023
@Moelf Moelf deleted the makie_recipe branch February 8, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makie.jl plotting recipe missing
2 participants