Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less typed return of fit #478

Merged
merged 2 commits into from
Mar 9, 2023
Merged

less typed return of fit #478

merged 2 commits into from
Mar 9, 2023

Conversation

jverzani
Copy link
Member

@jverzani jverzani commented Mar 9, 2023

Close issue #477 by relaxing overspecified type of polynomial returned by fit so that polynomial types with more that the {T,X} parameters can be fit.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (44679d0) 83.28% compared to head (70de7d0) 83.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #478   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files          24       24           
  Lines        3046     3046           
=======================================
  Hits         2537     2537           
  Misses        509      509           
Impacted Files Coverage Δ
src/common.jl 90.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jverzani jverzani merged commit f3669e3 into JuliaMath:master Mar 9, 2023
@jverzani jverzani deleted the issue_477 branch March 9, 2023 23:34
@jverzani jverzani mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant