Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #486

Merged
merged 3 commits into from
Mar 24, 2023
Merged

fix typos #486

merged 3 commits into from
Mar 24, 2023

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Mar 23, 2023

README.md
docs/src/index.md
src/common.jl
src/pade.jl
src/polynomials/ImmutablePolynomial.jl
src/polynomials/LaurentPolynomial.jl
src/polynomials/Poly.jl
src/polynomials/factored_polynomial.jl
src/polynomials/multroot.jl
src/polynomials/ngcd.jl
src/polynomials/standard-basis.jl
src/rational-functions/fit.jl
src/rational-functions/plot-recipes.jl
test/StandardBasis.jl

it's possible to add these

$ ed -s Polynomials.jl/README.md <<<'290,291p'
* `Pade`: Return the
  [Pade approximant](https://en.wikipedia.org/wiki/Pad%C3%A9_approximant) of order `m/n` for a polynomial as a `Pade` object.
$ 

sed -i "s/Pade approximant/Padé approximant/g" Polynomials.jl/README.md

this isn't a typo but is more standard

sed -i "s/parametrized/parameterized/g" Polynomials.jl/src/abstract.jl

@spaette spaette marked this pull request as draft March 23, 2023 01:22
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f5b20cd) 83.25% compared to head (9c1c8fe) 83.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files          24       24           
  Lines        3045     3045           
=======================================
  Hits         2535     2535           
  Misses        510      510           
Impacted Files Coverage Δ
src/abstract.jl 51.02% <ø> (ø)
src/common.jl 89.92% <0.00%> (ø)
src/pade.jl 97.72% <ø> (ø)
src/polynomials/ImmutablePolynomial.jl 91.86% <ø> (ø)
src/polynomials/LaurentPolynomial.jl 96.21% <ø> (ø)
src/polynomials/Poly.jl 81.81% <ø> (ø)
src/polynomials/factored_polynomial.jl 86.84% <ø> (ø)
src/polynomials/multroot.jl 93.44% <ø> (ø)
src/polynomials/ngcd.jl 83.15% <ø> (ø)
src/polynomials/standard-basis.jl 89.23% <ø> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jverzani
Copy link
Member

This is just great. Thank you so much!

@jverzani jverzani marked this pull request as ready for review March 23, 2023 16:00
@spaette
Copy link
Contributor Author

spaette commented Mar 23, 2023

@jverzani @jverzani

Can I change the spelling to Padé approximant in README.md?

Can I change the spelling as parametrized to parameterized in src/abstract.jl?

@jverzani
Copy link
Member

Sorry, yes, please do change those spellings. Thx

@jverzani
Copy link
Member

So, I'll merge once this all passed CI unless you want to add some more. Thanks again!

@spaette
Copy link
Contributor Author

spaette commented Mar 23, 2023

I was not inclined to add the acute accent (diacritic) in src/pade.jl.

That was my preference, but if you have a different opinion you can look at that file.

@jverzani
Copy link
Member

I'm fine either way. Let's leave as you have it.

@jverzani jverzani merged commit cfb4a82 into JuliaMath:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants