Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use Val with ntuple when the length isn't a constant #525

Merged
merged 1 commit into from
Aug 20, 2023
Merged

don't use Val with ntuple when the length isn't a constant #525

merged 1 commit into from
Aug 20, 2023

Commits on Aug 20, 2023

  1. don't use Val with ntuple when the length isn't a constant

    Helps type inference.
    
    Before:
    ```julia-repl
    julia> using Test, JET, Polynomials
    
    julia> p = ImmutablePolynomial{Bool, :x, 1}((true,))
    ImmutablePolynomial(true)
    
    julia> @inferred coeffs(p)
    ERROR: return type Tuple{Bool} does not match inferred return type Any
    ```
    
    After:
    ```julia-repl
    julia> using Test, JET, Polynomials
    
    julia> p = ImmutablePolynomial{Bool, :x, 1}((true,))
    ImmutablePolynomial(true)
    
    julia> @inferred coeffs(p)
    ERROR: return type Tuple{Bool} does not match inferred return type Tuple{Vararg{Bool}}
    ```
    nsajko committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    13ff12c View commit details
    Browse the repository at this point in the history