Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no special case for coeffs #528

Merged
merged 3 commits into from
Aug 21, 2023
Merged

no special case for coeffs #528

merged 3 commits into from
Aug 21, 2023

Conversation

jverzani
Copy link
Member

Issue #526 identifies a bug in the coeffs call for ImmutablePolynomials. This uses the fall back method, as intended.

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 90.90% and project coverage change: +0.16% 🎉

Comparison is base (aa9bec7) 76.59% compared to head (b6e7fb8) 76.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   76.59%   76.76%   +0.16%     
==========================================
  Files          35       35              
  Lines        3739     3740       +1     
==========================================
+ Hits         2864     2871       +7     
+ Misses        875      869       -6     
Files Changed Coverage Δ
src/polynomials/multroot.jl 58.42% <85.71%> (+0.47%) ⬆️
src/abstract-polynomial.jl 80.88% <100.00%> (+5.14%) ⬆️
...mial-container-types/immutable-dense-polynomial.jl 88.05% <100.00%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jverzani jverzani merged commit 28f31f7 into JuliaMath:master Aug 21, 2023
20 of 21 checks passed
@jverzani jverzani deleted the issue_526 branch August 21, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant