Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
quadgk
function type-stable. Closes #21. Closes #19. Closes #15. Closes #20.Also fixes handling of some other other number types, and in particular fixes dimensionful types (#17). Mostly supersedes https://github.com/PainterQubits/UnitfulIntegration.jl, cc @ajkeller34:
It still doesn't completely address #13, because it only works if
real(one(T))
returns the underlying real numeric type for computing the quadrature weights etc. This doesn't work for dual numbers (ForwardDiff.jl) or measurements (JuliaPhysics/Measurements.jl#31), and in general I haven't been able to think of a way to do this that works across packages.