-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Incomplete Beta Function ratios Ix(a,b) and Iy(a,b) #165
Conversation
A nice start! |
@Sumegh-git out of curiosity: do you run tests locally before pushing? Pushing a revision that you know is broken spawns 30+ CI jobs that are ineluctably going to fail (in addition to alerting every 10 minutes all people watching the repository) 😉 |
@giordano sorry for that. Usually I do, but these were minor tests and I thought they would pass surely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've flagged a few such changes. See how you go with these and the rest.
@simonbyrne made the changes as reviewed. Looking for more similar changes if any. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's a few more suggestions. The beta_inc
function is pretty complicated, so will probably take a few passes over it to clear up the control flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, get rid of the remaining print
statments, and SpecialFunctions.
prefixes.
Anything more @simonbyrne ? |
Done @simonbyrne . |
This is the initial code for computing the Incomplete Beta function Ix and Iy and returns a tuple similar to
gamma_inc
.This is based on the Didonato Paper as referred inside the code docstring for function
beta_inc
.Tests will be added soon.
Although I manually performed a few random tests with SciPy and they seem to be working fine.
Also will need to refactor the code to remove the
@goto
s.cc @simonbyrne