Use OpenLibm_jll instead of Base.libm #344
Conversation
This avoids making the assumption that `Base.libm` exists, which it may not once Julia's dependency on openlibm is excised.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 92.59% 92.61% +0.01%
==========================================
Files 12 12
Lines 2716 2722 +6
==========================================
+ Hits 2515 2521 +6
Misses 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is great! We should release a new version of the package. |
|
Good idea. Is this technically a breaking change? It should be entirely invisible to most users except for those with a custom build that uses a different libm (e.g. MKL if MKL provides a libm implementation, I'm not very familiar with it). |
|
This will not be a breaking change for this package. The custom MKL libm thing has not worked for a long time. It is in fact no longer in the julia build system. The main purpose for having a new version is that it propagates through the package ecosystem, so that when we do it upstream in Julia and prepare for 1.8, things won't break. |
This avoids making the assumption that
Base.libmexists, which it may not once Julia's dependency on openlibm is excised (cf. JuliaLang/julia#42299).