Fix deprecations #27
Fix deprecations #27
Conversation
| @@ -9,7 +9,7 @@ else | |||
|
|
|||
| provides(Binaries, URI("http://bitbucket.org/MDukhan/yeppp/downloads/yeppp-$ver.tar.bz2"), libyepppdep, unpacked_dir = "yeppp-$ver/binaries/windows/amd64/", os = :Windows) | |||
| provides(Binaries, URI("http://bitbucket.org/MDukhan/yeppp/downloads/yeppp-$ver.tar.bz2"), libyepppdep, unpacked_dir = "yeppp-$ver/binaries/macosx/x86_64/", os = :Darwin) | |||
| @linux_only push!(BinDeps.defaults, Binaries) | |||
| @compat @static is_linux() ? push!(BinDeps.defaults, Binaries) : nothing | |||
There was a problem hiding this comment.
this should also pop! back the BinDeps.defaults to what it was before when it's done
There was a problem hiding this comment.
and shouldn't actually need @compat here, just using Compat at the top - but change the minimum required version of Compat in the REQUIRE file to the version that introduced @static and is_linux.
There was a problem hiding this comment.
it will be a bug fix to add the pop. it should be here now but isn't.
There was a problem hiding this comment.
also JuliaLang/Compat.jl#209 for is_linux which was 0.7.20
There was a problem hiding this comment.
Thanks @tkelman, also we need to pop! just after the installation, i.e., @BinDeps.install, right?
There was a problem hiding this comment.
that's right. only on linux unless there's another push! I didn't see
Fixes the deprecation warnings.