Skip to content

Fixes for building on AArch64 with Clang #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fixes for building on AArch64 with Clang #314

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca166a0
Fix detection of whether `long double` is the same as `double`
ararslan Jan 7, 2025
42c2687
Fix setting of `USECLANG`/`USEGCC`
ararslan Jan 7, 2025
4d2d83f
Add a Vim filetype hint for Make.inc alongside that for Emacs
ararslan Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions Make.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# -*- mode: makefile-gmake -*-
# vi:ft=make

# Default build rule for any Makefile in this project: all
default: all
Expand Down Expand Up @@ -28,10 +29,6 @@ endif
# Just Run: make clean && make coverage -j
CODE_COVERAGE ?= 0

USEGCC ?= 1
USECLANG ?= 0
TOOLPREFIX ?=

ifneq (,$(findstring $(OS),Darwin FreeBSD OpenBSD))
USEGCC ?= 0
USECLANG ?= 1
Expand All @@ -49,10 +46,14 @@ USEGCC = 0
TOOLPREFIX = llvm-
endif

USEGCC ?= 1
USECLANG ?= 0
TOOLPREFIX ?=

AR := $(TOOLPREFIX)ar

ifeq ($(USECLANG),1)
USEGCC ?= 0
USEGCC = 0
CC = clang
CFLAGS_add += -fno-builtin -fno-strict-aliasing
endif
Expand Down Expand Up @@ -171,7 +172,7 @@ ifneq ($(filter $(ARCH),i387 amd64),)
# linux x86_64, for instance, `long double` is 80 bits wide, whereas on macOS aarch64,
# `long double` is the same as `double`.
LONG_DOUBLE_NOT_DOUBLE := 1
else ifeq ($(ARCH), aarch64 riscv64)
else ifeq ($(ARCH), aarch64)
ifeq ($(filter $(OS),Darwin WINNT),)
LONG_DOUBLE_NOT_DOUBLE := 1
endif
Expand Down
Loading