Improve threads and blocks tuning for 2D parallel_for (CUDA) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PhilipFackler does this work for your use case? |
|
Test this please |
|
@williamfgc It worked for the smallish test case I was using for development (one that caused the failure in the first place). I still want to test it out on iguazu with a bigger case. |
williamfgc
approved these changes
Jun 6, 2024
|
@PhilipFackler thanks, let me know when this is ready to merge. |
PhilipFackler
force-pushed
the
fix-cuda-thread-counts-2d
branch
2 times, most recently
from
0da2e97 to
66cd4b8
Compare
PhilipFackler
force-pushed
the
fix-cuda-thread-counts-2d
branch
from
66cd4b8 to
5b8f820
Compare
|
@williamfgc I added functors to change the behavior of getting |
|
@williamfgc I believe this is ready to merge. You'll want to request all the tests again. |
|
@williamfgc can you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #76 but for 2D. This only applies to the CUDA version.