Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs fixed in AMDGPU back end, indexes, group size in second kernel i… #42

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Bugs fixed in AMDGPU back end, indexes, group size in second kernel i… #42

merged 2 commits into from
Feb 20, 2024

Conversation

pedrovalerolara
Copy link
Collaborator

…nvocation, for 2D parallel_for and parallel_reduce implementations

@williamfgc
Copy link
Collaborator

Test this please

Copy link
Collaborator

@williamfgc williamfgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the temporary .swp file or .nfs*. It's probably left over from a previous session.
Also, we are doing CI with the latest ROCm 6 and AMDGPU.jl v0.8.6

@williamfgc
Copy link
Collaborator

@pedrovalerolara please fix conflict and rebase main so we can run the updated CI

@Geekdude
Copy link
Collaborator

.swp and .nfs should be added to .gitignore since these files should never be committed.

pedrovalerolara and others added 2 commits February 20, 2024 13:45
Bugs fixed in AMDGPU back end, indexes, group size in second kernel invocation, for 2D parallel_for and parallel_reduce implementations
Making some changes on CUDA back end too for 2D parallel_reduce implementation
@williamfgc
Copy link
Collaborator

Test this please

@williamfgc williamfgc merged commit b08faee into JuliaORNL:main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants