Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve getall/setall for staticarrays #108

Merged
merged 5 commits into from
May 17, 2023
Merged

Conversation

aplavin
Copy link
Member

@aplavin aplavin commented May 15, 2023

Now, it's more consistent:

  • getall comptime-known length: Tuple
  • getall runtime length: Vector

This change lets them nicely propagate and infer for both get- and setall.

Non-breaking: container types were specifically allowed to change in getall docsting.

@aplavin aplavin mentioned this pull request May 16, 2023
6 tasks
@aplavin
Copy link
Member Author

aplavin commented May 16, 2023

@jw3126 would really appreciate a look/review here!
I find this code basically required for any nontrivial getall/setall use with staticarrays. Would you please check that everything looks fine?

Project.toml Show resolved Hide resolved
Copy link
Member

@jw3126 jw3126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aplavin aplavin merged commit 79ee865 into JuliaObjects:master May 17, 2023
@aplavin aplavin deleted the allsvec branch May 17, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants