Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errors in extensions during precompilation #127 #128

Closed
wants to merge 2 commits into from
Closed

Conversation

jw3126
Copy link
Member

@jw3126 jw3126 commented Jan 9, 2024

This reverts #121
We can reactivate it when the bug is fixed on mainstream julia versions.

Fix #127

@jw3126
Copy link
Member Author

jw3126 commented Jan 9, 2024

@aplavin LGTY?

@aplavin
Copy link
Member

aplavin commented Jan 9, 2024

Not at the computer with git and ide right now, cannot correct myself.
I think the smallest change is just to change Project.toml as you did, and remove if here

@static if !isdefined(Base, :get_extension)
so that includes are always executed. Keeping all other files intact.
This will keep the separation for the future.

@jw3126
Copy link
Member Author

jw3126 commented Jan 9, 2024

I tried that first, but julia still complains, they are also listed in Project.toml as extensions etc. So it is multiple places to edit. So I think it is better to revert and later we can resurrect the full commit.

@aplavin
Copy link
Member

aplavin commented Jan 9, 2024

Tried to make a PR with github web interface, but accidentally made an actual commit, sorry for that... Should work I think, let's wait for test.

@jw3126
Copy link
Member Author

jw3126 commented Jan 9, 2024

Well okay that is also fine I guess.

@jw3126 jw3126 closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in extensions during precompilation
2 participants