Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Add get_quadratic_constraint and fix getting of quadratic function #24

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

odow
Copy link
Member

@odow odow commented Jun 11, 2018

@joaquimg I'm not sure what the story is with Xpress but I needed these changes for Gurobi.

In particular, Gurobi counts linear rows separately from quadratic rows :(

The docs also say that get_quadratic_constraint returns 1-indexed columns. We probably need to check that this happens everywhere?

@odow odow mentioned this pull request Jun 11, 2018
12 tasks
@codecov-io
Copy link

codecov-io commented Jun 11, 2018

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   56.21%   56.21%           
=======================================
  Files          13       13           
  Lines        1062     1062           
=======================================
  Hits          597      597           
  Misses        465      465
Impacted Files Coverage Δ
src/solver_interface.jl 50% <ø> (ø) ⬆️
src/constraints/scalaraffine.jl 74.38% <0%> (ø) ⬆️
src/constraints/scalarquadratic.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b43ed...99bb45d. Read the comment docs.

@odow odow mentioned this pull request Jun 11, 2018
14 tasks
@joaquimg
Copy link
Member

Those look good! I will modify xpress

@odow odow merged commit cefa4d2 into master Jun 11, 2018
@odow odow deleted the odow/quad branch June 11, 2018 23:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants