Extend support of LinearQuadratic interface in NonlinearToLPQPBridge. #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… solver interface. Tests included.
|
LGTM! I'm not pointing out style issues since MPB is deprecated and will be replaced by MOI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a use case for setobj!, addconstr!, addvar!, delconstrs! when solving a quadratic program with Ipopt, which was not supported in the NonlinearToLPQPBridge. This adds support for most of the LinearQuadratic interface functions in the NonlinearToLPQPBridge and should be functional with Ipopt at least. I have my fork as a test dependency at the moment, but I thought this could be useful for others as well.
I Added a linprogsolvertest of IpoptSolver, with absolute tolerance 1e-5 as in nlp tests (I had to pass fixed_variable_treatment="make_constraint" to Ipopt to get correct reduced costs in the fixed variable case).
Passes all tests locally.