Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Julia 1.0 and Julia LTS #21

Merged
merged 14 commits into from
Jan 27, 2023
Merged

Test on Julia 1.0 and Julia LTS #21

merged 14 commits into from
Jan 27, 2023

Conversation

devmotion
Copy link
Member

We should test at least the oldest Julia version that we claim to support as well. I have seen in many projects how easy it is to accidentally introduce changes that break compatibility with older versions such as Julia 1.0. IMO it's fine to introduce them and drop support for e.g. Julia < 1.6 (I think generally one should aim for supporting at least Julia LTS) but if we don't run the tests we won't notice these incompatibilities.

Additionally, the PR removes tests with '1.8' since that is (currently) the same as '1' anyway ('1' points to the latest stable Julia release which is 1.8 at the moment). Instead I propose testing the LTS version as well, i.e., (currently) Julia 1.6.

@coveralls
Copy link

coveralls commented Jan 25, 2023

Pull Request Test Coverage Report for Build 4024781255

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.207%

Totals Coverage Status
Change from base Build 4001884408: 0.0%
Covered Lines: 25
Relevant Lines: 29

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 86.20% // Head: 86.20% // No change to project coverage 👍

Coverage data is based on head (876bbc1) compared to base (cf375e5).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files           3        3           
  Lines          29       29           
=======================================
  Hits           25       25           
  Misses          4        4           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zsteve
Copy link
Member

zsteve commented Jan 27, 2023

Thanks for the PR and the explanation, I agree. I guess part of it was playing around with the breaking CI. Seems to be a libraries issue with v1.6

@devmotion
Copy link
Member Author

The issue is JuliaPy/PyCall.jl#999, and the solution is to enforce the use of the Conda-version of libstdc++ with LD_PRELOAD.

@zsteve
Copy link
Member

zsteve commented Jan 27, 2023

The issue is JuliaPy/PyCall.jl#999, and the solution is to enforce the use of the Conda-version of libstdc++ with LD_PRELOAD.

Hmm it still seems like Julia 1.6 with ubuntu-latest - x64 - conda is failing due to this workaround.

ERROR: ld.so: object '$HOME/.julia/conda/3/lib/libstdc++.so.6' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.

Maybe it's worth bypassing the requirements this time?

@devmotion
Copy link
Member Author

I wanted to fix it today, unfortunately didn't manage to continue with this PR yesterday.

@zsteve
Copy link
Member

zsteve commented Jan 27, 2023

Yeah sorry for the mess, can't reproduce any of this on my local machine so just tweaking and seeing what CI does.

@devmotion
Copy link
Member Author

OK, everything works apart from Windows + Julia 1.0. This remaining test failure is caused by JuliaPy/Conda.jl#230.

@devmotion devmotion merged commit a3c1d24 into main Jan 27, 2023
@devmotion devmotion deleted the dw/ci branch January 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants