Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionvalues for ValueIterationPolicy #22

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Conversation

MaximeBouton
Copy link
Contributor

wait for JuliaLang/METADATA.jl#19154 and restart build before merging.

@codecov-io
Copy link

codecov-io commented Oct 28, 2018

Codecov Report

Merging #22 into master will decrease coverage by 44.1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
- Coverage   97.87%   53.76%   -44.11%     
===========================================
  Files           1        1               
  Lines          47       93       +46     
===========================================
+ Hits           46       50        +4     
- Misses          1       43       +42
Impacted Files Coverage Δ
src/vanilla.jl 53.76% <100%> (-44.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9be196...0c80f44. Read the comment docs.

@MaximeBouton
Copy link
Contributor Author

A potential suspect for the sudden decrease of coverage: JuliaLang/julia#28192
thanks @rejuvyesh for pointing that out.

@MaximeBouton MaximeBouton merged commit 442e128 into master Oct 29, 2018
@MaximeBouton MaximeBouton deleted the actionvalues branch October 29, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants