Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #261 for Linux #266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

americast
Copy link

@americast americast commented Feb 26, 2017

Fixes issue #261 for Arch Linux.
Adds deps/build.jl

Gramercy.

@codecov-io
Copy link

codecov-io commented Feb 26, 2017

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #266   +/-   ##
======================================
  Coverage    0.14%   0.14%           
======================================
  Files           4       4           
  Lines         683     683           
======================================
  Hits            1       1           
  Misses        682     682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4654b03...3682bc3. Read the comment docs.

Copy link
Contributor

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distribition detection seems very fragile. You should maybe just check the presence of pacman. The command also shouldn't be run unconditionally, at most when the zip command is missing.

@americast americast changed the title Fix #261 for Arch Linux Fix #261 for Linux Feb 27, 2017
@americast
Copy link
Author

@yuyichao Incorporated the changes you requested. Also added support for multiple distros.

Gramercy.

@tkelman
Copy link
Contributor

tkelman commented Feb 27, 2017

shouldn't rely on which being installed, there are environments where it isn't by default

@americast
Copy link
Author

americast commented Feb 27, 2017

@tkelman Removed which.

Gramercy.

@tkelman
Copy link
Contributor

tkelman commented Feb 27, 2017

won't this be susceptible to #199?

@americast
Copy link
Author

americast commented Feb 27, 2017

@tkelman Yes, it will be. Can you suggest any workaround ?

Gramercy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants