-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #261 for Linux #266
base: master
Are you sure you want to change the base?
Fix #261 for Linux #266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
======================================
Coverage 0.14% 0.14%
======================================
Files 4 4
Lines 683 683
======================================
Hits 1 1
Misses 682 682 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distribition detection seems very fragile. You should maybe just check the presence of pacman
. The command also shouldn't be run unconditionally, at most when the zip
command is missing.
@yuyichao Incorporated the changes you requested. Also added support for multiple distros. Gramercy. |
shouldn't rely on which being installed, there are environments where it isn't by default |
@tkelman Removed Gramercy. |
won't this be susceptible to #199? |
@tkelman Yes, it will be. Can you suggest any workaround ? Gramercy. |
Fixes issue #261 for Arch Linux.
Adds deps/build.jl
Gramercy.