Skip to content

Commit

Permalink
Fix suggestion to use expand_cxxstring_abis (#620)
Browse files Browse the repository at this point in the history
  • Loading branch information
maleadt authored and staticfloat committed Jan 16, 2020
1 parent 76badfe commit f4ba291
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/auditor/compiler_abi.jl
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ function check_libstdcxx_version(oh::ObjectHandle, platform::Platform; verbose::
# msg = strip(replace("""
# $(path(oh)) links to libstdc++! This causes incompatibilities across
# major versions of GCC. To remedy this, you must build a tarball for
# each major version of GCC. To do this, immediately after your `products`
# each major version of GCC. To do this, immediately after your `platforms`
# definition in your `build_tarballs.jl` file, add the line:
# """, '\n' => ' '))
# msg *= "\n\n products = expand_cxx_versions(products)"
# msg *= "\n\n platforms = expand_cxxstring_abis(platforms)"
# warn(io, msg)
# return false
# end
Expand Down Expand Up @@ -182,10 +182,10 @@ function check_cxxstring_abi(oh::ObjectHandle, platform::Platform; io::IO = stdo
msg = strip(replace("""
$(path(oh)) contains std::string values! This causes incompatibilities across
the GCC 4/5 version boundary. To remedy this, you must build a tarball for
both GCC 4 and GCC 5. To do this, immediately after your `products`
both GCC 4 and GCC 5. To do this, immediately after your `platforms`
definition in your `build_tarballs.jl` file, add the line:
""", '\n' => ' '))
msg *= "\n\n products = expand_cxx_versions(products)"
msg *= "\n\n platforms = expand_cxxstring_abis(platforms)"
@warn(msg)
return false
end
Expand Down

0 comments on commit f4ba291

Please sign in to comment.