Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hanging tests #1175

Merged
merged 5 commits into from
Feb 28, 2022
Merged

Fix hanging tests #1175

merged 5 commits into from
Feb 28, 2022

Conversation

giordano
Copy link
Member

No description provided.

@giordano giordano marked this pull request as draft February 27, 2022 19:44
@giordano
Copy link
Member Author

giordano commented Feb 27, 2022

@staticfloat jobs are hanging at

[ Info: Start setting up the server...
[ Info: creating tarball...
[ Info: Registering artifact...
[ Info: Creating server...
[ Info: Trying port 14444
[ Info: Yggdrasil directory: /data/staticfloat/bb_azp/rootfs/agent_2/_work/1/s/deps/Yggdrasil
[ Info: Cloning bare Yggdrasil into deps/Yggdrasil...
[ Info: Yggdrasil directory: /data/staticfloat/bb_azp/rootfs/agent_2/_work/1/s/deps/Yggdrasil

yggdrasil_dir = abspath(joinpath(@__DIR__, "..", "..", "deps", "Yggdrasil"))
@info "Yggdrasil directory: $(yggdrasil_dir)"
if !isdir(yggdrasil_dir)
@info( "Cloning bare Yggdrasil into deps/Yggdrasil...")
LibGit2.clone("https://github.com/JuliaPackaging/Yggdrasil.git", yggdrasil_dir; isbare=true)

Can you please check what's going on in that directory? I'm also surprised the directory doesn't exist, since the cache directory should be always the same, no?

@giordano
Copy link
Member Author

Nevermind, that was a red herring, it's actually hanging at

[ Info: Start setting up the server...
[ Info: creating tarball...
[ Info: Registering artifact...
[ Info: Creating server...
[ Info: Trying port 14444
[ Info: port 14444 is good, move on
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:90
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:127
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:130
┌ Info: Using cached git repository
│   url = "[https://github.com/JuliaPackaging/Yggdrasil.git"](https://github.com/JuliaPackaging/Yggdrasil.git%22)
└   repo_path = "/data/staticfloat/bb_azp/rootfs/agent_1/storage/downloads/clones/Yggdrasil.git-a5a98df475347605e8bd1e4db910f627874e12e32c926834f439d470461da54b"
[ Info: Updating bare Yggdrasil clone in deps/Yggdrasil...
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:136
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:141
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:143
┌ Info: Using cached git repository
│   url = "[https://github.com/JuliaPackaging/Yggdrasil.git"](https://github.com/JuliaPackaging/Yggdrasil.git%22)
└   repo_path = "/data/staticfloat/bb_azp/rootfs/agent_1/storage/downloads/clones/Yggdrasil.git-a5a98df475347605e8bd1e4db910f627874e12e32c926834f439d470461da54b"
[ Info: /data/staticfloat/bb_azp/rootfs/agent_1/_work/1/s/test/wizard.jl:145

which is

call_response(ins, outs, "Enter a name for this project", "libcurl")
@info "$(@__FILE__):$(@__LINE__)"
, but it's weird, we haven't touched the src/wizard directory since January 10th, way before tests started hanging.

@giordano
Copy link
Member Author

Ok, good news is that I get the hang at the same point also locally, so at least it should be easier to debug. I'll try to find some time next week. Still weird this is happening only now....

@giordano
Copy link
Member Author

Oh, I see, it's because of JuliaPackaging/Yggdrasil#4472 🤦 🤦

Yggdrasil pull request JuliaPackaging/Yggdrasil#4472
deleted the file `L/LibCURL/build_tarballs.jl`, which made the test checking
that the file exists fail.  Arguably, we should make the check more robust, but
it'd be considerably more work for relatively little gain (vast majority of
packages do follow the predictable naming scheme).
@giordano giordano changed the title Debug hanging CI jobs Fix hanging tests Feb 28, 2022
@giordano giordano marked this pull request as ready for review February 28, 2022 02:11
@giordano giordano merged commit 1795408 into JuliaPackaging:master Feb 28, 2022
@giordano giordano deleted the mg/debug-ci branch February 28, 2022 02:12
@staticfloat
Copy link
Member

How ironic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants