Fix dead cxxstring_abi code paths
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
force-pushed
the
sf/cxxstringabi_testing
branch
from
7f33280 to
55773f3
Compare
staticfloat
force-pushed
the
sf/cxxstringabi_testing
branch
from
55773f3 to
f4670fe
Compare
We were accidentally stripping out ABI information from our platform objects while generating compiler wrappers, resulting in `cxxstring_abi` settings being ignored. In order to ensure that this does not happen again, we've added some more tests ensuring that when we ask to build a `cxx11` library, we actually get what we asked for.
staticfloat
force-pushed
the
sf/cxxstringabi_testing
branch
from
f4670fe to
caa443d
Compare
giordano
reviewed
Jan 16, 2020
| unpack(tarball_path, testdir) | ||
| prefix = Prefix(testdir) | ||
|
|
||
| # Ensure that the library detects as the correct cxxstring_abi: |
There was a problem hiding this comment.
Maybe add also a unit test on cppfilt that checks it returns what is supposed to?
giordano
reviewed
Jan 16, 2020
Co-Authored-By: Mosè Giordano <giordano@users.noreply.github.com>
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidentally stripping out ABI information from our platform
objects while generating compiler wrappers, resulting in
cxxstring_abisettings being ignored. In order to ensure that this does not happen
again, we've added some more tests ensuring that when we ask to build a
cxx11library, we actually get what we asked for.Also, the
cppfilt()function wasn't working at all because I forgot toseek(input, 0)before sending it into therun_interactive().