Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the full triplet to the build script. #619

Closed
wants to merge 1 commit into from

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Jan 16, 2020

I need this (target + ABI) to download the LLVMBuilder output:

script = raw"""
wget -nv https://github.com/staticfloat/LLVMBuilder/releases/download/v8.0.1+4/LLVM.asserts.v8.0.1.${triplet}.tar.gz
...
"""

EDIT: I ended up adding the download as a regular sources entry, so I don't strictly need this anymore.

@giordano
Copy link
Member

I'd just note that with #604 this will always be a fully specified triplet.

@maleadt
Copy link
Contributor Author

maleadt commented Jan 16, 2020

Oh OK, I'll just wait then :-)

@maleadt maleadt closed this Jan 16, 2020
@giordano
Copy link
Member

Well, we still need to add the variable if you need it 🙂

@maleadt
Copy link
Contributor Author

maleadt commented Jan 16, 2020

Ah, sorry, I misunderstood 🙂

@maleadt maleadt reopened this Jan 16, 2020
@staticfloat
Copy link
Member

I'm adding this in #644.

staticfloat added a commit that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants