Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslibroot for macOS needs to be manually fixed also for GCC v5 #630

Closed
wants to merge 2 commits into from

Conversation

giordano
Copy link
Member

Fix error reported in #381 (comment), observed in JuliaPackaging/Yggdrasil#421.

@staticfloat
Copy link
Member

Can we get a MWE for something that requires the syslibroot set like this? I want to run this against all the platforms and see if it's actually needed for more than just GCC 4/5. And I'd like to set up a test so it doesn't bitrot. :)

@giordano
Copy link
Member Author

HelloWorldFortran reproduces the error when building for x86_64-apple-darwin14-libgfortran3 with GCC v5

@staticfloat
Copy link
Member

Okay so it looks like we dodge this in the default testsuite but not in HelloWorldFortran because in the default testsuite, we actually run $(FC) -c -o blah.o blah.f and then run $(CC) -o blah blah.o, so the thing doing the linking is $(CC) which is clang. Whereas in HelloWorldFortran, we directly run $(FC) -o blah blah.f, which means that it's actually gfortran doing the linking.

I will update the test suite to compile HelloWorldFortran twice so we can exercise both codepaths.

@staticfloat
Copy link
Member

I've got a slightly different testing approach bundled in with #640, so once that goes green we can just merge that. Thanks for the find!

@giordano giordano deleted the macos-syslibroot branch January 30, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants