build_tarballs: fix call to get_meta_json #874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, I screwed up in PR #872 -- this hopefully fixes it. I only noticed it when I wanted to add a
julia_dependencieskwarg... I hope I got it right now. It's a bit frightening that there is no test forbuild_tarballs()in there at all, though... Perhaps at least the variant with--meta-jsoncould be tested, which likely would have caught this one?I also wonder if perhaps @staticfloat's work in #861 can be used to test (in the test suite) the generation of a full JLL, locally, by outputting it into a temporary directory; and then perhaps
diffcould be used to compare it to a pregenerated copy, so that any changes are detected. (Of course one could then also repeat this with different settings used).