Discourage -fomit-frame-pointer

JuliaPackaging · Jul 14, 2023 · 1d17fab · 1d17fab
1 parent 21a1c77
commit 1d17fab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Runner.jl b/src/Runner.jl
@@ -542,7 +542,7 @@ function generate_compiler_wrappers!(platform::AbstractPlatform; bin_path::Abstr
 
  function gcc_unsafe_flags!(p::AbstractPlatform, flags::Vector{String} = String[])
  if !allow_unsafe_flags
- return String["-Ofast", "-ffast-math", "-funsafe-math-optimizations"]
+ return String["-Ofast", "-ffast-math", "-funsafe-math-optimizations", "-fomit-frame-pointer"]
  end
  return String[]
  end

diff --git a/test/runners.jl b/test/runners.jl
@@ -390,7 +390,7 @@ end
  @test !run(ur, cmd, iobuff; tee_stream=devnull)
  seekstart(iobuff)
  lines = readlines(iobuff)
- @test lines[2] == "BinaryBuilder: You used one or more of the unsafe flags: -Ofast, -ffast-math, -funsafe-math-optimizations"
+ @test lines[2] == "BinaryBuilder: You used one or more of the unsafe flags: -Ofast, -ffast-math, -funsafe-math-optimizations, -fomit-frame-pointer"
  @test lines[3] == "Please repent."
 
  ur = preferred_runner()(dir; platform=platform, allow_unsafe_flags=true)