Improve relocatability of sysimages with BBBase #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create a const artifacts_toml with @path - use envcache to determine the version instead of parsing the project.toml: Using @path here doesn't work as - a: Project.toml which at DIR*.. - b: the entire `src` would be stored in the Path object (and not Project.toml) - While creating storage_cache check if "deps_path" is valid else create one at dev/BBBase.jl/deps: Even here using @path directly is of no use as you are creating a new folder and don't intend any file to survive relocation So now it checks if the path is valid; ow creates one at .julia/dev Leaving this storage_cache untouched will result in creating a folder identical to original-depot-path failing all the RelocatableFolder's `getpath` efforts
giordano
requested changes
Feb 8, 2022
src/BinaryBuilderBase.jl
Outdated
| function get_bbb_version(dir=@__DIR__, uuid="7f725544-6523-48cd-82d1-3fa08ff4056e") | ||
| # Get BinaryBuilder.jl's version and git sha | ||
| version = Pkg.TOML.parsefile(joinpath(dir, "..", "Project.toml"))["version"] | ||
| version = Pkg.activate(".") do |
There was a problem hiding this comment.
Note that you're ignoring dir. This breaks https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/11af33aadd1d502bfd2c90a7c8382e2550439580/src/BinaryBuilder.jl#L53-L54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
artifact_tomlpaths are defined using@__DIR__. This hardwires the paths. Any sysimage with BinaryBuilderBase thus becomes non-relocatable. Particularly, any function that downloads artifacts throws an IOerror for not finding<original_package_location>/Project.toml(Similarly
get_bbb_versionis suitably modified)