Don't override authentication callbacks in libgit2 clone #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the supported callbacks interface rather than trying to re-do the low level interface. As reported in JuliaPackaging/BinaryBuilder.jl#1287, we currently try to error when attempting to clone a repository over ssh (either directly or via the insteadOf git setting), because we accidentally override the base callback to provide ssh credentials. Fixes JuliaPackaging/BinaryBuilder.jl#1287
- Setup a temporary SSH key, so that cloning from SSH works - Don't use deprecated syntax for progress bar - Make sure to actually test the progress bar case on CI, which is what was broken before.
Env vars are apparently not shared, so it can't find the agent
We ship GitHub's keys in julia, but the keys that were current when older julia versions were released have since been rotated by GitHub, so we need to keyscan (if we were relying on this for MITM security, not just testing, we'd want to ship known keys, but here it doesn't matter if the remote is actually github or not).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the supported callbacks interface rather than trying to re-do the low level interface. As reported in JuliaPackaging/BinaryBuilder.jl#1287, we currently try to error when attempting to clone a repository over ssh (either directly or via the insteadOf git setting), because we accidentally override the base callback to provide ssh credentials.
Fixes JuliaPackaging/BinaryBuilder.jl#1287