Upgrade to Julia 1.6+ #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Sep 24, 2020
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
giordano
reviewed
Sep 24, 2020
Member
Author
|
Yeah, we don’t have CPUID for it yet so I figured we’d just leave it out
for now.
…On Thu, Sep 24, 2020 at 11:40 Mosè Giordano ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/rootfs.jl
<#38 (comment)>
:
> + Platform("i686", "linux"; libc="glibc", march="prescott"),
+ Platform("powerpc64le", "linux"; libc="glibc", march="power8"),
+ Platform("powerpc64le", "linux"; libc="glibc", march="power9"),
⬇️ Suggested change
- Platform("i686", "linux"; libc="glibc", march="prescott"),
- Platform("powerpc64le", "linux"; libc="glibc", march="power8"),
- Platform("powerpc64le", "linux"; libc="glibc", march="power9"),
+ Platform("i686", "linux"; libc="glibc", march="i686"),
+ Platform("i686", "linux"; libc="glibc", march="prescott"),
+ Platform("powerpc64le", "linux"; libc="glibc", march="power8"),
This should make the test pass, but we're missing power9 in the expansion?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA762C4EET7UEKXNQ5S6Y3SHOHCTANCNFSM4RYR46PQ>
.
|
This was referenced Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.