Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some very basic tests #95

Closed
wants to merge 1 commit into from
Closed

Add some very basic tests #95

wants to merge 1 commit into from

Conversation

musm
Copy link
Contributor

@musm musm commented Jan 17, 2017

At a bare minimum this should be much better than no tests

@musm
Copy link
Contributor Author

musm commented Jan 17, 2017

Someone will have to activate appveyor to have this work

@tkelman
Copy link
Contributor

tkelman commented Jan 17, 2017

If this package had an uninstall capability then it would make the most sense to check whether or not these are installed already, and clean them up afterwards if they aren't

@musm
Copy link
Contributor Author

musm commented Jan 17, 2017

Is there anything wrong with having at least something as basic as this to catch out bugs that one might miss from local testing. When WinRPM has better uninstall options they can be added later?

@tkelman
Copy link
Contributor

tkelman commented Jan 17, 2017

How many megabytes of stuff does this download upon Pkg.test that you might not need/want?

@tkelman
Copy link
Contributor

tkelman commented Jan 17, 2017

testing is good, but if possible we should try to do so in a clean, temporary, test-only environment that we delete afterwards

@musm
Copy link
Contributor Author

musm commented Jan 17, 2017

Good point.

Unrelated
Could you merge: JuliaIO/JLDArchives.jl#10
None of the JLDArchives PRs actually run travis without those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants