Not a valid application error on windows

[barche]

On PR's #2339 and #7899 the executables or DLL for Windows result in "not a valid Win32 application" errors. The problem comes from the libgcc.a, libgcc_s.a and libmsvcrt.a that is placed in /workspace/destdir/lib by CompilerSupportLibraries_jll. I'm not sure under which circumstances it is triggered (it seems quite rare), but when this occurs removing these files solves the problem.

[sloede]

AFAICT, the location of the offending libraries depends on the Julia version. For the moment, it is

• no libraries for Julia <= 1.8
• $prefix/lib/ for Julia 1.9 and 1.10
• $prefix/lib/gcc/<triple>/<major>/ for Julia >= 1.11
  where <triple> is the usual BB triplet (e.g., x86_64-w64-mingw32) and <major> is the GCC compiler major version (e.g., 13) (see also [CompilerSupportLibraries] Upgrade to GCC 13 and move Win *.a files to subdir #7535).

[vtjnash]

So this should be fixed for Julia >= 1.11 I think, since we now hide those .a files in subfolders

[giordano]

I'm not entirely sure, but I believe

Yggdrasil/S/SDPA/build_tarballs.jl

Lines 67 to 69 in d4808d4

	if [[ ${target} == *mingw* ]]; then
	# Needed for https://github.com/JuliaLang/julia/issues/48081
	export LDFLAGS="-L/opt/$target/$target/sys-root/lib"

was used to work around this problem. Maybe @blegat can confirm.

[odow]

That doesn't appear to have worked around the issue because we're now hitting this:
jump-dev/SDPA.jl#57

[odow]

Just confirming that #8249 fixed this for SDPA.

https://github.com/jump-dev/SDPA.jl/actions/runs/8197171105/job/22418710526?pr=61