Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update openfhe-julia to v0.2.0 #7899

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Update openfhe-julia to v0.2.0 #7899

merged 9 commits into from
Jan 4, 2024

Conversation

sloede
Copy link
Contributor

@sloede sloede commented Jan 3, 2024

No description provided.

@sloede sloede changed the title WIP: Update openfhe-julia to v0.2.0 Update openfhe-julia to v0.2.0 Jan 3, 2024
@sloede sloede changed the title Update openfhe-julia to v0.2.0 WIP: Update openfhe-julia to v0.2.0 Jan 3, 2024
@sloede sloede changed the title WIP: Update openfhe-julia to v0.2.0 Update openfhe-julia to v0.2.0 Jan 3, 2024
@sloede sloede marked this pull request as ready for review January 3, 2024 22:27
@sloede
Copy link
Contributor Author

sloede commented Jan 3, 2024

@giordano ready for review & merge from my POV

@barche
Copy link
Contributor

barche commented Jan 4, 2024

I see this PR uses libjulia_jll version 1.10.8, but the latest libcxxwrap_julia_jll is built using version 1.10.7, but I think this is harmless since libsingular does the same.

@sloede
Copy link
Contributor Author

sloede commented Jan 4, 2024 •
edited
Loading

I see this PR uses libjulia_jll version 1.10.8, but the latest libcxxwrap_julia_jll is built using version 1.10.7, but I think this is harmless since libsingular does the same.

True, but libsingular does not build on Windows, so there's no telling if it would have an impact there.

Just to be on the safe side, I changed the libjulia_jll and preferred GCC version to be identical to libcxxwrap-julia's settings in 60c2711.

Could you applying RTLD_GLOBAL for libcxxwrap-julia have any effect that I should consider here as well?

@sloede sloede closed this Jan 4, 2024
@sloede sloede reopened this Jan 4, 2024
@barche barche mentioned this pull request Jan 4, 2024
Open
@sloede sloede closed this Jan 4, 2024
@sloede sloede reopened this Jan 4, 2024
@sloede
Copy link
Contributor Author

sloede commented Jan 4, 2024

@barche Any idea what's going on here:
https://buildkite.com/julialang/yggdrasil/builds/7543#018cd43a-c16b-42d9-90f2-087d4cf1a5f5/604-807

@sloede
Copy link
Contributor Author

sloede commented Jan 4, 2024

@barche I think I figured it out: With the newest build of CSL from Oct 2023 (only for Julia v1.11+), the location of the offending libraries has been moved to lib/gcc/<triple>/<major> (see #7535). I ended up using the following, somewhat defensive code that seems to work for all Julia versions (including pre-1.9 versions that do not have these libraries at all). If you find the time, it would be great if you could confirm that the build products indeed work for you.

@giordano Since all builds succeed now, it would be great if this could be merged.

@gbaraldi gbaraldi merged commit 57c0ba2 into JuliaPackaging:master Jan 4, 2024
13 checks passed
@sloede sloede deleted the msl/openfhe-v0.2.0 branch January 4, 2024 19:24
MichelJuillard pushed a commit to MichelJuillard/Yggdrasil that referenced this pull request Jan 8, 2024
@sloede @barche @MichelJuillard
Update openfhe-julia to v0.2.0 (JuliaPackaging#7899)
002c9b6 
* Update openfhe-julia to v0.2.0

* Hopefully fix build errors

* Set repo hash to actual release hash

* Use same libjulia_jll and GCC versions as libcxxwrap-julia

* Apply fix from GnuPlot_jll for mingw

* Rewrap comment

* Fix remove pattern

* Remove offending libraries from _all_ directories

* Make less defensive

---------

Co-authored-by: Bart Janssens <bart@bartjanssens.org>
@odow odow mentioned this pull request Mar 7, 2024
Merged
grasph pushed a commit to Moelf/Yggdrasil that referenced this pull request Jul 1, 2024
@sloede @barche @grasph
Update openfhe-julia to v0.2.0 (JuliaPackaging#7899)
c65659c 
* Update openfhe-julia to v0.2.0

* Hopefully fix build errors

* Set repo hash to actual release hash

* Use same libjulia_jll and GCC versions as libcxxwrap-julia

* Apply fix from GnuPlot_jll for mingw

* Rewrap comment

* Fix remove pattern

* Remove offending libraries from _all_ directories

* Make less defensive

---------

Co-authored-by: Bart Janssens <bart@bartjanssens.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloede @barche @gbaraldi