-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protobuf, protoc versioning #9796
Comments
@eschnett What do you think? |
stemann
added a commit
to stemann/Yggdrasil
that referenced
this issue
Nov 16, 2024
Used by ONNX v1.11.0 (and in turn, Torch v1.12.1). Removed notes about protobuf version numbers, cf. JuliaPackaging#9796.
stemann
added a commit
to stemann/Yggdrasil
that referenced
this issue
Nov 16, 2024
Used by ONNX v1.11.0 (and in turn, Torch v1.12.1). Removed notes about protobuf version numbers, cf. JuliaPackaging#9796. No libabsl or libutf8 products produced for this version.
Err... ldd /mnt/bin/protoc
# ...
libprotoc.so.3.16.0.0 => /mnt/bin/../lib/libprotoc.so.3.16.0.0 (0x00007f75a6400000)
libprotobuf.so.3.16.0.0 => /mnt/bin/../lib/libprotobuf.so.3.16.0.0 (0x00007f75a6000000)
# ...
ldd /mtn/lib/libprotoc.so.3.16.0.0
# ...
libprotobuf.so.3.16.0.0 => /mnt/lib/libprotobuf.so.3.16.0.0 (0x00007f54f5800000)
# ...
ldd /mnt/lib/libprotobuf.so.3.16.0.0
# ...
ldd /mnt/lib/libprotobuf-lite.so.3.16.0.0
# ...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems there were some confusion regarding the version numbering scheme of the protobuf project, the protobuf C++ library, and the libprotobuf-dependent protoc compiler, in #8658 (protoc_jll v26.1), and in particular in #9584 (protoc_jll v105.28.2).
It seems that the protobuf project, and protoc compiler is versioned using major version number >= 21, since protobuf C++ library version 3.21.0: https://protobuf.dev/support/version-support/
And in addition, using major versions > 3, since minor versions v16.2, v.18.3, v19.5, v20.2 (also tagged as v3.x.y, e.g. v3.16.2).
IIUC, #8658 was right (wrt. to the package name and the package version - reflecting the proper protoc compiler version).
Would it be right to migrate to having two JLL's, e.g.
protoc_jll
containing only the protoc compiler, andprotobuf_cpp_jll
containing the protobuf C++ library?An attempt at an overview - and a suggested versioning plan:
References:
The text was updated successfully, but these errors were encountered: