Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder for Opus #165

Merged
merged 5 commits into from
Nov 12, 2019
Merged

Add builder for Opus #165

merged 5 commits into from
Nov 12, 2019

Conversation

giordano
Copy link
Member

@giordano giordano commented Oct 26, 2019

Dependency of sdl2_mixer (#122).

This doesn't work only on aarch64, during make I get:

libtool: compile:  cc -std=gnu99 -DHAVE_CONFIG_H -I. -I./include -I./celt -I./silk -I./silk/float -I./silk/fixed -g -O2 -fvisibility=hidden -D_FORTIFY_SOURCE=2 -W -Wall -Wextra -Wcast-align -Wnested-externs -Wshadow -Wstrict-prototypes -MT celt/arm/celt_neon_intr.lo -MD -MP -MF celt/arm/.deps/celt_neon_intr.Tpo -c celt/arm/celt_neon_intr.c  -fPIC -DPIC -o celt/arm/.libs/celt_neon_intr.o
In file included from celt/arm/celt_neon_intr.c:37:0:
celt/arm/celt_neon_intr.c: In function ‘xcorr_kernel_neon_float’:
celt/arm/celt_neon_intr.c:137:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YY[0], vget_low_f32(XX[0]), 0);
              ^
celt/arm/celt_neon_intr.c:139:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[0], vget_low_f32(XX[0]), 1);
              ^
celt/arm/celt_neon_intr.c:141:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[1], vget_high_f32(XX[0]), 0);
              ^
celt/arm/celt_neon_intr.c:143:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[2], vget_high_f32(XX[0]), 1);
              ^
celt/arm/celt_neon_intr.c:145:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YY[1], vget_low_f32(XX[1]), 0);
              ^
celt/arm/celt_neon_intr.c:147:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[0], vget_low_f32(XX[1]), 1);
              ^
celt/arm/celt_neon_intr.c:149:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[1], vget_high_f32(XX[1]), 0);
              ^
celt/arm/celt_neon_intr.c:151:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[2], vget_high_f32(XX[1]), 1);
              ^
celt/arm/celt_neon_intr.c:170:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YY[0], vget_low_f32(XX[0]), 0);
              ^
celt/arm/celt_neon_intr.c:172:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[0], vget_low_f32(XX[0]), 1);
              ^
celt/arm/celt_neon_intr.c:174:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[1], vget_high_f32(XX[0]), 0);
              ^
celt/arm/celt_neon_intr.c:176:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YEXT[2], vget_high_f32(XX[0]), 1);
              ^
celt/arm/celt_neon_intr.c:184:14: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
       SUMM = vmlaq_lane_f32(SUMM, YY[0], XX_2, 0);
              ^
celt/arm/celt_neon_intr.c:189:11: error: incompatible types when initializing type ‘float32x4_t’ using type ‘float32x2_t’
    SUMM = vmlaq_lane_f32(SUMM, YY[0], XX_2, 0);
           ^

@giordano giordano added the multimedia 🎧 Issues and builders related to multimedia libraries label Oct 26, 2019
@staticfloat staticfloat closed this Nov 8, 2019
@staticfloat staticfloat reopened this Nov 8, 2019
This might fix our AArch64 NEON issues
@staticfloat staticfloat closed this Nov 8, 2019
@staticfloat staticfloat reopened this Nov 8, 2019
@giordano giordano marked this pull request as ready for review November 12, 2019 00:02
@staticfloat staticfloat marked this pull request as ready for review November 12, 2019 00:06
@staticfloat staticfloat merged commit 9d1d345 into JuliaPackaging:master Nov 12, 2019
@giordano giordano deleted the opus branch November 12, 2019 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multimedia 🎧 Issues and builders related to multimedia libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants