Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise libsingular_julia #1798

Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented Oct 16, 2020

The build dependencies on GMP_jll and MPFR_jll were only implicit so far,
but we need to make them explicit and with version constraints to avoid
issues on macOS (when this JLL is built against a too-new version of either
of these libraries, it becomes unloadable in older Julia versions).

Supporting more platforms is kind of an experiment. I am not sure what impediments there are (other than the lack of libcxxwrap_julia binaries for some -- but I hope that once libjulia_jll 1.4 is ready, @barche will be willing to update libcxxwrap_julia to use libjulia_jll, at which point it could probably cover all (?) platforms. But we'll see.

Closes #2203

@fingolfin fingolfin closed this Oct 16, 2020
@fingolfin fingolfin reopened this Oct 16, 2020
@barche
Copy link
Contributor

barche commented Oct 16, 2020

but I hope that once libjulia_jll 1.4 is ready, @barche will be willing to update libcxxwrap_julia to use libjulia_jll

Holding out a bit for libjulia 1.3, then I can release a libcxxwrap based on that, immediately followed by one based on 1.4 with a Julia compat requirement of 1.4.

@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from 8f05130 to d52de3a Compare October 17, 2020 00:29
@fingolfin fingolfin closed this Oct 17, 2020
@fingolfin fingolfin reopened this Oct 17, 2020
@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from 8df9534 to 8b0dac3 Compare October 17, 2020 00:58
@fingolfin

This comment has been minimized.

@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from bda7be4 to 0c13d87 Compare November 21, 2020 23:01
@fingolfin fingolfin changed the title libsingular_julia: more platforms and make build deps explicit Revise libsingular_julia Nov 21, 2020
@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from 2b3eed7 to 28e26eb Compare November 21, 2020 23:40
@fingolfin fingolfin marked this pull request as ready for review November 21, 2020 23:46
@fingolfin
Copy link
Member Author

@barche @giordano This is now ready for review; see also issue #2160 for an explanation on what's going on. Since this might eventually become template for a bunch of other packages, before merging the whole approach should be scrutinized.

@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from 28e26eb to a904a48 Compare December 9, 2020 13:05
@fingolfin fingolfin closed this Dec 9, 2020
@fingolfin fingolfin reopened this Dec 9, 2020
@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from a904a48 to 8a7803a Compare December 9, 2020 16:21
@fingolfin fingolfin closed this Dec 11, 2020
@fingolfin fingolfin reopened this Dec 11, 2020
@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch 2 times, most recently from 14592f0 to 4c0388b Compare December 11, 2020 21:21
Adapt to latest CxxWrap; in particular, build separate binaries for each
minor Julia version (1.3, 1.4, 1.5, ...)

This also adds support for more platforms.

The build dependencies on GMP_jll and MPFR_jll were only implicit so far,
but we need to make them explicit and with version constraints to avoid
issues on macOS (when this JLL is built against a too-new version of either
of these libraries, it becomes unloadable in older Julia versions)
@fingolfin fingolfin force-pushed the mh/tweak-libsingular_julia branch from 4c0388b to 9c475be Compare December 15, 2020 09:52
@fingolfin
Copy link
Member Author

@thofma @benlorenz I think this is ready -- it changes the version from 0.2.x to 0.3.x, so it should be safe to merge this now, as it won't be "accidentally" used by the current Singular.jl release. Once merged, I'd wait with the corresponding updates for Julia 1.4 and 1.5 until after we confirmed this one works with an updated Singular.jl

That said, we can't really update Singular.jl to use it until Nemocas/Nemo.jl#919 is merged and Nemo.jl gets a new release...

CC @fieker

Copy link
Contributor

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I did a quick test on a gcc9 based linux machine with the binaries from here via override, dev'ing the various downstream packages, adjusting a bunch of project files (versions + deps) and using the flint 2.7 pull request branch:

...
   Testing Singular tests passed 

@fingolfin
Copy link
Member Author

Thanks @benlorenz that's awesome

@giordano
Copy link
Member

Good to go then?

@fingolfin
Copy link
Member Author

Yes, please

@giordano giordano merged commit 972a70d into JuliaPackaging:master Dec 15, 2020
@fingolfin fingolfin deleted the mh/tweak-libsingular_julia branch December 16, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants