-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise libsingular_julia #1798
Revise libsingular_julia #1798
Conversation
Holding out a bit for libjulia 1.3, then I can release a libcxxwrap based on that, immediately followed by one based on 1.4 with a Julia compat requirement of 1.4. |
8f05130
to
d52de3a
Compare
8df9534
to
8b0dac3
Compare
This comment has been minimized.
This comment has been minimized.
bda7be4
to
0c13d87
Compare
2b3eed7
to
28e26eb
Compare
28e26eb
to
a904a48
Compare
a904a48
to
8a7803a
Compare
14592f0
to
4c0388b
Compare
Adapt to latest CxxWrap; in particular, build separate binaries for each minor Julia version (1.3, 1.4, 1.5, ...) This also adds support for more platforms. The build dependencies on GMP_jll and MPFR_jll were only implicit so far, but we need to make them explicit and with version constraints to avoid issues on macOS (when this JLL is built against a too-new version of either of these libraries, it becomes unloadable in older Julia versions)
4c0388b
to
9c475be
Compare
@thofma @benlorenz I think this is ready -- it changes the version from 0.2.x to 0.3.x, so it should be safe to merge this now, as it won't be "accidentally" used by the current Singular.jl release. Once merged, I'd wait with the corresponding updates for Julia 1.4 and 1.5 until after we confirmed this one works with an updated Singular.jl That said, we can't really update Singular.jl to use it until Nemocas/Nemo.jl#919 is merged and Nemo.jl gets a new release... CC @fieker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I did a quick test on a gcc9 based linux machine with the binaries from here via override, dev'ing the various downstream packages, adjusting a bunch of project files (versions + deps) and using the flint 2.7 pull request branch:
...
Testing Singular tests passed
Thanks @benlorenz that's awesome |
Good to go then? |
Yes, please |
The build dependencies on GMP_jll and MPFR_jll were only implicit so far,
but we need to make them explicit and with version constraints to avoid
issues on macOS (when this JLL is built against a too-new version of either
of these libraries, it becomes unloadable in older Julia versions).
Supporting more platforms is kind of an experiment. I am not sure what impediments there are (other than the lack of
libcxxwrap_julia
binaries for some -- but I hope that once libjulia_jll 1.4 is ready, @barche will be willing to updatelibcxxwrap_julia
to uselibjulia_jll
, at which point it could probably cover all (?) platforms. But we'll see.Closes #2203