Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCCBootstrap] Patch avx512fintrin #2415

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

omus
Copy link
Contributor

@omus omus commented Jan 18, 2021

Closes #2389. This is my first time patching the root bundle so let be know if I missed anything. I believe I named the patch appropriately using the first GCC version affected.

Here's the original patch: gcc-mirror/gcc@23bce99#diff-c3bbd1dcd7c953ef6d719969fb187e31209ef3d7851a84448aad949aea2e8106. I'll note I'm currently only patching the header file (as was mentioned here: #2385 (comment)) but we may want to apply the entire patch.

Edit: I see now that the other code change only applies to the tests so just patching the header should be fine.

@omus
Copy link
Contributor Author

omus commented Jan 18, 2021

Note this patch doesn't apply to GCC 6 as _mm512_abs_pd and _mm512_mask_abs_pd are not defined

@omus
Copy link
Contributor Author

omus commented Jan 18, 2021

I've also confirmed the that patch is not needed on GCC 9.1.0

@omus omus force-pushed the cv/patch-gcc-avx512fintrin branch from 6d68f80 to 11450fe Compare January 18, 2021 17:52
@omus
Copy link
Contributor Author

omus commented Jan 18, 2021

With this patch it should be safe to remove the dasum_microk_skylakex-typecast.patch patches from OpenBLAS*@0.3.12

@giordano
Copy link
Member

Note this patch doesn't apply to GCC 6 as _mm512_abs_pd and _mm512_mask_abs_pd are not defined

Yeah, they were introduced in gcc-mirror/gcc@dcb2c52, which, according to the tags, appeared first in a release in 7.1.0. Good that only two versions are affected then! I'll try to rebuild the x86_64 shards in the next few days

@giordano
Copy link
Member

I started building GCC 7 a few minutes ago, hopefully in less than 24 hours I'll finish to build all needed shards.... ⏳

@omus
Copy link
Contributor Author

omus commented Jan 20, 2021

Bump

@giordano
Copy link
Member

Relevant GCC shards updated in JuliaPackaging/BinaryBuilderBase.jl#101. Thanks!

@giordano giordano merged commit c3c60d8 into JuliaPackaging:master Jan 21, 2021
giordano added a commit to giordano/Yggdrasil that referenced this pull request Jan 21, 2021
giordano added a commit that referenced this pull request Jan 21, 2021
Get new fixed x86_64 shards for GCC 7 and 8, see
#2415 and
JuliaPackaging/BinaryBuilderBase.jl#101.
@omus omus deleted the cv/patch-gcc-avx512fintrin branch January 21, 2021 03:04
@giordano giordano mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch for old GCC versions
2 participants